Closed
Bug 1342665
Opened 8 years ago
Closed 8 years ago
Disable header sorting for js/
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
Details
Attachments
(1 file)
By default, clang-format is going to sort the headers.
This is breaking the test:
make -C obj-x86_64-pc-linux-gnu/js/src/ check-style
[..]
--- check_spider_monkey_style.py expected output
+++ check_spider_monkey_style.py actual output
@@ -1,5 +1,209 @@
+js/src/tests/style/HeaderCycleB4-inl.h:1:2: error:
+ "tests/style/HeaderCycleB1-inl.h" should be included after "tests/style/jsheadercycleB5inlines.h"
+
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sledru
|
|
Assignee | |
Comment 1•8 years ago
|
||
| noise | ||
| Comment hidden (mozreview-request) |
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8842375 [details]
Bug 1342665 - Disable header sorting for js/
https://reviewboard.mozilla.org/r/116252/#review117942
Looks good.
Attachment #8842375 -
Flags: review?(jolesen) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9790d28380c2
Disable header sorting for js/ r=jolesen
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•3 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•